feat: add Gemini provider support for image generation #7945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XL
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for your contribution! I've reviewed the changes and found some issues that need attention. The implementation looks solid overall, but there are critical issues with test coverage and model configuration that should be addressed.
Critical Issues:
- Missing test coverage - The existing test file only tests OpenRouter but doesn't include any tests for the new Gemini provider functionality.
- Model ID mismatch - The PR description mentions using gemini-2.0-flash-exp but the code uses gemini-2.5-flash-image-preview.
| // For Gemini, we can use the existing Gemini API key from the provider settings | ||
| // Check for a dedicated image generation API key first, then fall back to the provider's API key | ||
| apiKey = | ||
| state?.geminiImageApiKey || |
There was a problem hiding this comment.
This fallback to the main Gemini API key is a nice touch for user convenience. However, could we add a comment here explaining this fallback behavior so future maintainers understand the logic?
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
- Create centralized image generation models configuration in types package - Implement generateImage() method in Gemini provider for text-to-image and image-to-image - Add provider dropdown in UI settings to switch between OpenRouter and Gemini - Update generateImageTool to route requests to appropriate provider - Add settings persistence for Gemini API key and model selection - Translate all new UI strings across 18 supported languages - Fix settings state management to properly handle new image generation settings
Address PR review feedback by using the correct Content type from the Gemini SDK for the contents array in generateImage method
The provider state was being updated inside the effect while also being included in the dependency array, which could cause unnecessary re-renders or potential infinite loops. Fixed by using a local newProvider variable to calculate the correct selected model before updating state.
hannesrudolph
force-pushed
the
feat/gemini-image-generation
branch
from
d7a20fd to
71c2bcf
Compare
Review SummaryAll previously identified issues have been addressed or acknowledged:
Code Review Complete - No additional issues found. The implementation follows existing patterns, maintains type safety, and integrates cleanly with the codebase architecture. |
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the Gemini provider for image generation, allowing users to choose between OpenRouter and Gemini for generating images.
Changes
Features
Architecture
UI/UX
Internationalization
Settings Management
Testing
Breaking Changes
None - maintains full backward compatibility with existing OpenRouter integration